chore: commit remaining workspace changes

backend/src/api/routes/settings.py

@@ -31,7 +31,38 @@ class LoggingConfigResponse(BaseModel):
     enable_belief_state: bool
 # [/DEF:LoggingConfigResponse:Class]
 
-router = APIRouter()
+router = APIRouter()
+
+
+# [DEF:_normalize_superset_env_url:Function]
+# @PURPOSE: Canonicalize Superset environment URL to base host/path without trailing /api/v1.
+# @PRE: raw_url can be empty.
+# @POST: Returns normalized base URL.
+def _normalize_superset_env_url(raw_url: str) -> str:
+    normalized = str(raw_url or "").strip().rstrip("/")
+    if normalized.lower().endswith("/api/v1"):
+        normalized = normalized[:-len("/api/v1")]
+    return normalized.rstrip("/")
+# [/DEF:_normalize_superset_env_url:Function]
+
+
+# [DEF:_validate_superset_connection_fast:Function]
+# @PURPOSE: Run lightweight Superset connectivity validation without full pagination scan.
+# @PRE: env contains valid URL and credentials.
+# @POST: Raises on auth/API failures; returns None on success.
+def _validate_superset_connection_fast(env: Environment) -> None:
+    client = SupersetClient(env)
+    # 1) Explicit auth check
+    client.authenticate()
+    # 2) Single lightweight API call to ensure read access
+    client.get_dashboards_page(
+        query={
+            "page": 0,
+            "page_size": 1,
+            "columns": ["id"],
+        }
+    )
+# [/DEF:_validate_superset_connection_fast:Function]
 
 # [DEF:get_settings:Function]
 # @PURPOSE: Retrieves all application settings.
@@ -112,14 +143,18 @@ async def update_storage_settings(
 # @PRE:     Config manager is available.
 # @POST:    Returns list of environments.
 # @RETURN: List[Environment] - List of environments.
-@router.get("/environments", response_model=List[Environment])
-async def get_environments(
+@router.get("/environments", response_model=List[Environment])
+async def get_environments(
     config_manager: ConfigManager = Depends(get_config_manager),
     _ = Depends(has_permission("admin:settings", "READ"))
-):
-    with belief_scope("get_environments"):
-        logger.info("[get_environments][Entry] Fetching environments")
-    return config_manager.get_environments()
+):
+    with belief_scope("get_environments"):
+        logger.info("[get_environments][Entry] Fetching environments")
+    environments = config_manager.get_environments()
+    return [
+        env.copy(update={"url": _normalize_superset_env_url(env.url)})
+        for env in environments
+    ]
 # [/DEF:get_environments:Function]
 
 # [DEF:add_environment:Function]
@@ -129,21 +164,21 @@ async def get_environments(
 # @PARAM: env (Environment) - The environment to add.
 # @RETURN: Environment - The added environment.
 @router.post("/environments", response_model=Environment)
-async def add_environment(
-    env: Environment,
+async def add_environment(
+    env: Environment,
     config_manager: ConfigManager = Depends(get_config_manager),
     _ = Depends(has_permission("admin:settings", "WRITE"))
-):
-    with belief_scope("add_environment"):
-        logger.info(f"[add_environment][Entry] Adding environment {env.id}")
+):
+    with belief_scope("add_environment"):
+        logger.info(f"[add_environment][Entry] Adding environment {env.id}")
+    env = env.copy(update={"url": _normalize_superset_env_url(env.url)})
     
-    # Validate connection before adding
-    try:
-        client = SupersetClient(env)
-        client.get_dashboards(query={"page_size": 1})
-    except Exception as e:
-        logger.error(f"[add_environment][Coherence:Failed] Connection validation failed: {e}")
-        raise HTTPException(status_code=400, detail=f"Connection validation failed: {e}")
+    # Validate connection before adding (fast path)
+    try:
+        _validate_superset_connection_fast(env)
+    except Exception as e:
+        logger.error(f"[add_environment][Coherence:Failed] Connection validation failed: {e}")
+        raise HTTPException(status_code=400, detail=f"Connection validation failed: {e}")
 
     config_manager.add_environment(env)
     return env
@@ -157,28 +192,29 @@ async def add_environment(
 # @PARAM: env (Environment) - The updated environment data.
 # @RETURN: Environment - The updated environment.
 @router.put("/environments/{id}", response_model=Environment)
-async def update_environment(
+async def update_environment(
     id: str,
     env: Environment,
     config_manager: ConfigManager = Depends(get_config_manager)
-):
+):
     with belief_scope("update_environment"):
         logger.info(f"[update_environment][Entry] Updating environment {id}")
     
-    # If password is masked, we need the real one for validation
-    env_to_validate = env.copy(deep=True)
+    env = env.copy(update={"url": _normalize_superset_env_url(env.url)})
+
+    # If password is masked, we need the real one for validation
+    env_to_validate = env.copy(deep=True)
     if env_to_validate.password == "********":
         old_env = next((e for e in config_manager.get_environments() if e.id == id), None)
         if old_env:
             env_to_validate.password = old_env.password
 
-    # Validate connection before updating
-    try:
-        client = SupersetClient(env_to_validate)
-        client.get_dashboards(query={"page_size": 1})
-    except Exception as e:
-        logger.error(f"[update_environment][Coherence:Failed] Connection validation failed: {e}")
-        raise HTTPException(status_code=400, detail=f"Connection validation failed: {e}")
+    # Validate connection before updating (fast path)
+    try:
+        _validate_superset_connection_fast(env_to_validate)
+    except Exception as e:
+        logger.error(f"[update_environment][Coherence:Failed] Connection validation failed: {e}")
+        raise HTTPException(status_code=400, detail=f"Connection validation failed: {e}")
 
     if config_manager.update_environment(id, env):
         return env
@@ -208,7 +244,7 @@ async def delete_environment(
 # @PARAM: id (str) - The ID of the environment to test.
 # @RETURN: dict - Success message or error.
 @router.post("/environments/{id}/test")
-async def test_environment_connection(
+async def test_environment_connection(
     id: str,
     config_manager: ConfigManager = Depends(get_config_manager)
 ):
@@ -220,15 +256,11 @@ async def test_environment_connection(
     if not env:
         raise HTTPException(status_code=404, detail=f"Environment {id} not found")
     
-    try:
-        # Initialize client (this will trigger authentication)
-        client = SupersetClient(env)
-        
-        # Try a simple request to verify
-        client.get_dashboards(query={"page_size": 1})
-        
-        logger.info(f"[test_environment_connection][Coherence:OK] Connection successful for {id}")
-        return {"status": "success", "message": "Connection successful"}
+    try:
+        _validate_superset_connection_fast(env)
+        
+        logger.info(f"[test_environment_connection][Coherence:OK] Connection successful for {id}")
+        return {"status": "success", "message": "Connection successful"}
     except Exception as e:
         logger.error(f"[test_environment_connection][Coherence:Failed] Connection failed for {id}: {e}")
         return {"status": "error", "message": str(e)}