linter + новые таски

backend/tests/test_auth.py

@@ -1,5 +1,4 @@
 import sys
-import os
 from pathlib import Path
 
 # Add src to path
@@ -8,7 +7,7 @@ sys.path.append(str(Path(__file__).parent.parent / "src"))
 import pytest
 from sqlalchemy import create_engine
 from sqlalchemy.orm import sessionmaker
-from src.core.database import Base, get_auth_db
+from src.core.database import Base
 from src.models.auth import User, Role, Permission, ADGroupMapping
 from src.services.auth_service import AuthService
 from src.core.auth.repository import AuthRepository

backend/tests/test_dashboards_api.py

@@ -0,0 +1,67 @@
+# [DEF:backend.tests.test_dashboards_api:Module]
+# @TIER: STANDARD
+# @PURPOSE: Contract-driven tests for Dashboard Hub API
+# @RELATION: TESTS -> backend.src.api.routes.dashboards
+
+from fastapi.testclient import TestClient
+from unittest.mock import MagicMock, patch
+from src.app import app
+from src.api.routes.dashboards import DashboardsResponse
+
+client = TestClient(app)
+
+# [DEF:test_get_dashboards_success:Function]
+# @TEST: GET /api/dashboards returns 200 and valid schema
+# @PRE: env_id exists
+# @POST: Response matches DashboardsResponse schema
+def test_get_dashboards_success():
+    with patch("src.api.routes.dashboards.get_config_manager") as mock_config, \
+         patch("src.api.routes.dashboards.get_resource_service") as mock_service, \
+         patch("src.api.routes.dashboards.has_permission") as mock_perm:
+        
+        # Mock environment
+        mock_env = MagicMock()
+        mock_env.id = "prod"
+        mock_config.return_value.get_environments.return_value = [mock_env]
+        
+        # Mock resource service response
+        mock_service.return_value.get_dashboards_with_status.return_value = [
+            {
+                "id": 1,
+                "title": "Sales Report",
+                "slug": "sales",
+                "git_status": {"branch": "main", "sync_status": "OK"},
+                "last_task": {"task_id": "task-1", "status": "SUCCESS"}
+            }
+        ]
+        
+        # Mock permission
+        mock_perm.return_value = lambda: True
+
+        response = client.get("/api/dashboards?env_id=prod")
+        
+        assert response.status_code == 200
+        data = response.json()
+        assert "dashboards" in data
+        assert len(data["dashboards"]) == 1
+        assert data["dashboards"][0]["title"] == "Sales Report"
+        # Validate against Pydantic model
+        DashboardsResponse(**data)
+
+# [DEF:test_get_dashboards_env_not_found:Function]
+# @TEST: GET /api/dashboards returns 404 if env_id missing
+# @PRE: env_id does not exist
+# @POST: Returns 404 error
+def test_get_dashboards_env_not_found():
+    with patch("src.api.routes.dashboards.get_config_manager") as mock_config, \
+         patch("src.api.routes.dashboards.has_permission") as mock_perm:
+        
+        mock_config.return_value.get_environments.return_value = []
+        mock_perm.return_value = lambda: True
+
+        response = client.get("/api/dashboards?env_id=nonexistent")
+        
+        assert response.status_code == 404
+        assert "Environment not found" in response.json()["detail"]
+
+# [/DEF:backend.tests.test_dashboards_api:Module]

backend/tests/test_log_persistence.py

@@ -6,9 +6,7 @@
 # @TIER: STANDARD
 
 # [SECTION: IMPORTS]
-import pytest
 from datetime import datetime
-from unittest.mock import Mock, patch, MagicMock
 from sqlalchemy import create_engine
 from sqlalchemy.orm import sessionmaker
 

backend/tests/test_logger.py

@@ -1,5 +1,4 @@
 import pytest
-import logging
 from src.core.logger import (
     belief_scope,
     logger,

backend/tests/test_models.py

@@ -1,4 +1,3 @@
-import pytest
 from src.core.config_models import Environment
 from src.core.logger import belief_scope
 

backend/tests/test_resource_hubs.py

@@ -0,0 +1,123 @@
+import pytest
+from fastapi.testclient import TestClient
+from unittest.mock import MagicMock
+from src.app import app
+from src.dependencies import get_config_manager, get_task_manager, get_resource_service, has_permission
+
+client = TestClient(app)
+
+# [DEF:test_dashboards_api:Test]
+# @PURPOSE: Verify GET /api/dashboards contract compliance
+# @TEST: Valid env_id returns 200 and dashboard list
+# @TEST: Invalid env_id returns 404
+# @TEST: Search filter works
+
+@pytest.fixture
+def mock_deps():
+    config_manager = MagicMock()
+    task_manager = MagicMock()
+    resource_service = MagicMock()
+    
+    # Mock environment
+    env = MagicMock()
+    env.id = "env1"
+    config_manager.get_environments.return_value = [env]
+    
+    # Mock tasks
+    task_manager.get_all_tasks.return_value = []
+    
+    # Mock dashboards
+    resource_service.get_dashboards_with_status.return_value = [
+        {"id": 1, "title": "Sales", "slug": "sales", "git_status": {"branch": "main", "sync_status": "OK"}, "last_task": None},
+        {"id": 2, "title": "Marketing", "slug": "mkt", "git_status": None, "last_task": {"task_id": "t1", "status": "SUCCESS"}}
+    ]
+    
+    app.dependency_overrides[get_config_manager] = lambda: config_manager
+    app.dependency_overrides[get_task_manager] = lambda: task_manager
+    app.dependency_overrides[get_resource_service] = lambda: resource_service
+    
+    # Bypass permission check
+    mock_user = MagicMock()
+    mock_user.username = "testadmin"
+    
+    # Override both get_current_user and has_permission
+    from src.dependencies import get_current_user
+    app.dependency_overrides[get_current_user] = lambda: mock_user
+    
+    # We need to override the specific instance returned by has_permission
+    app.dependency_overrides[has_permission("plugin:migration", "READ")] = lambda: mock_user
+    
+    yield {
+        "config": config_manager,
+        "task": task_manager,
+        "resource": resource_service
+    }
+    
+    app.dependency_overrides.clear()
+
+def test_get_dashboards_success(mock_deps):
+    response = client.get("/api/dashboards?env_id=env1")
+    assert response.status_code == 200
+    data = response.json()
+    assert "dashboards" in data
+    assert len(data["dashboards"]) == 2
+    assert data["dashboards"][0]["title"] == "Sales"
+    assert data["dashboards"][0]["git_status"]["sync_status"] == "OK"
+
+def test_get_dashboards_not_found(mock_deps):
+    response = client.get("/api/dashboards?env_id=invalid")
+    assert response.status_code == 404
+
+def test_get_dashboards_search(mock_deps):
+    response = client.get("/api/dashboards?env_id=env1&search=Sales")
+    assert response.status_code == 200
+    data = response.json()
+    assert len(data["dashboards"]) == 1
+    assert data["dashboards"][0]["title"] == "Sales"
+
+# [/DEF:test_dashboards_api:Test]
+
+# [DEF:test_datasets_api:Test]
+# @PURPOSE: Verify GET /api/datasets contract compliance
+# @TEST: Valid env_id returns 200 and dataset list
+# @TEST: Invalid env_id returns 404
+# @TEST: Search filter works
+# @TEST: Negative - Service failure returns 503
+
+def test_get_datasets_success(mock_deps):
+    mock_deps["resource"].get_datasets_with_status.return_value = [
+        {"id": 1, "table_name": "orders", "schema": "public", "database": "db1", "mapped_fields": {"total": 10, "mapped": 5}, "last_task": None}
+    ]
+    
+    response = client.get("/api/datasets?env_id=env1")
+    assert response.status_code == 200
+    data = response.json()
+    assert "datasets" in data
+    assert len(data["datasets"]) == 1
+    assert data["datasets"][0]["table_name"] == "orders"
+    assert data["datasets"][0]["mapped_fields"]["mapped"] == 5
+
+def test_get_datasets_not_found(mock_deps):
+    response = client.get("/api/datasets?env_id=invalid")
+    assert response.status_code == 404
+
+def test_get_datasets_search(mock_deps):
+    mock_deps["resource"].get_datasets_with_status.return_value = [
+        {"id": 1, "table_name": "orders", "schema": "public", "database": "db1", "mapped_fields": {"total": 10, "mapped": 5}, "last_task": None},
+        {"id": 2, "table_name": "users", "schema": "public", "database": "db1", "mapped_fields": {"total": 5, "mapped": 5}, "last_task": None}
+    ]
+    
+    response = client.get("/api/datasets?env_id=env1&search=orders")
+    assert response.status_code == 200
+    data = response.json()
+    assert len(data["datasets"]) == 1
+    assert data["datasets"][0]["table_name"] == "orders"
+
+def test_get_datasets_service_failure(mock_deps):
+    mock_deps["resource"].get_datasets_with_status.side_effect = Exception("Superset down")
+    
+    response = client.get("/api/datasets?env_id=env1")
+    assert response.status_code == 503
+    assert "Failed to fetch datasets" in response.json()["detail"]
+
+# [/DEF:test_datasets_api:Test]

backend/tests/test_resource_service.py

@@ -0,0 +1,47 @@
+# [DEF:backend.tests.test_resource_service:Module]
+# @TIER: STANDARD
+# @PURPOSE: Contract-driven tests for ResourceService
+# @RELATION: TESTS -> backend.src.services.resource_service
+
+import pytest
+from unittest.mock import MagicMock, patch
+from src.services.resource_service import ResourceService
+
+@pytest.mark.asyncio
+async def test_get_dashboards_with_status():
+    # [DEF:test_get_dashboards_with_status:Function]
+    # @TEST: ResourceService correctly enhances dashboard data
+    # @PRE: SupersetClient returns raw dashboards
+    # @POST: Returned dicts contain git_status and last_task
+    
+    with patch("src.services.resource_service.SupersetClient") as mock_client, \
+         patch("src.services.resource_service.GitService") as mock_git:
+        
+        service = ResourceService()
+        
+        # Mock Superset response
+        mock_client.return_value.get_dashboards_summary.return_value = [
+            {"id": 1, "title": "Test Dashboard", "slug": "test"}
+        ]
+        
+        # Mock Git status
+        mock_git.return_value.get_repo.return_value = None # No repo
+        
+        # Mock tasks
+        mock_task = MagicMock()
+        mock_task.id = "task-123"
+        mock_task.status = "RUNNING"
+        mock_task.params = {"resource_id": "dashboard-1"}
+        
+        env = MagicMock()
+        env.id = "prod"
+        
+        result = await service.get_dashboards_with_status(env, [mock_task])
+        
+        assert len(result) == 1
+        assert result[0]["id"] == 1
+        assert "git_status" in result[0]
+        assert result[0]["last_task"]["task_id"] == "task-123"
+        assert result[0]["last_task"]["status"] == "RUNNING"
+
+# [/DEF:backend.tests.test_resource_service:Module]

backend/tests/test_task_logger.py

@@ -6,13 +6,10 @@
 # @TIER: STANDARD
 
 # [SECTION: IMPORTS]
-import pytest
-from unittest.mock import Mock, MagicMock
-from datetime import datetime
+from unittest.mock import Mock
 
 from src.core.task_manager.task_logger import TaskLogger
 from src.core.task_manager.context import TaskContext
-from src.core.task_manager.models import LogEntry
 # [/SECTION]
 
 # [DEF:TestTaskLogger:Class]