codex specify

backend/src/api/routes/__tests__/test_assistant_api.py

@@ -10,6 +10,7 @@ import os
 import asyncio
 from types import SimpleNamespace
 from datetime import datetime, timedelta
+import pytest
 
 # Force isolated sqlite databases for test module before dependencies import.
 os.environ.setdefault("DATABASE_URL", "sqlite:////tmp/ss_tools_assistant_api.db")
@@ -446,7 +447,7 @@ def test_list_conversations_groups_by_conversation_and_marks_archived():
             conversation_id="conv-old",
             role="user",
             text="old chat",
-            created_at=now - timedelta(days=assistant_module.ASSISTANT_ARCHIVE_AFTER_DAYS + 2),
+            created_at=now - timedelta(days=32), # Hardcoded threshold+2
         )
     )
 
@@ -536,7 +537,7 @@ def test_list_conversations_archived_only_filters_active():
             conversation_id="conv-archived-2",
             role="user",
             text="archived",
-            created_at=now - timedelta(days=assistant_module.ASSISTANT_ARCHIVE_AFTER_DAYS + 3),
+            created_at=now - timedelta(days=33), # Hardcoded threshold+3
         )
     )
 
@@ -624,5 +625,25 @@ def test_guarded_operation_confirm_roundtrip():
     assert second.task_id is not None
 
 
+# [DEF:test_confirm_nonexistent_id_returns_404:Function]
+# @PURPOSE: Confirming a non-existent ID should raise 404.
+# @PRE: user tries to confirm a random/fake UUID.
+# @POST: FastAPI HTTPException with status 404.
+def test_confirm_nonexistent_id_returns_404():
+    from fastapi import HTTPException
+    _clear_assistant_state()
+    with pytest.raises(HTTPException) as exc:
+        _run_async(
+            assistant_module.confirm_operation(
+                confirmation_id="non-existent-id",
+                current_user=_admin_user(),
+                task_manager=_FakeTaskManager(),
+                config_manager=_FakeConfigManager(),
+                db=_FakeDb(),
+            )
+        )
+    assert exc.value.status_code == 404
+
+
 # [/DEF:test_guarded_operation_confirm_roundtrip:Function]
 # [/DEF:backend.src.api.routes.__tests__.test_assistant_api:Module]

backend/src/api/routes/__tests__/test_migration_routes.py

@@ -249,6 +249,7 @@ def _make_sync_config_manager(environments):
     config.environments = environments
     cm = MagicMock()
     cm.get_config.return_value = config
+    cm.get_environments.return_value = environments
     return cm
 
 
@@ -343,4 +344,67 @@ async def test_trigger_sync_now_idempotent_env_upsert(db_session, _mock_env):
     assert env_count == 1
 
 
+# --- get_dashboards tests ---
+
+@pytest.mark.asyncio
+async def test_get_dashboards_success(_mock_env):
+    from src.api.routes.migration import get_dashboards
+    cm = _make_sync_config_manager([_mock_env])
+    
+    with patch("src.api.routes.migration.SupersetClient") as MockClient:
+        mock_client = MagicMock()
+        mock_client.get_dashboards_summary.return_value = [{"id": 1, "title": "Test"}]
+        MockClient.return_value = mock_client
+        
+        result = await get_dashboards(env_id="test-env-1", config_manager=cm, _=None)
+        assert len(result) == 1
+        assert result[0]["id"] == 1
+
+@pytest.mark.asyncio
+async def test_get_dashboards_invalid_env_raises_404(_mock_env):
+    from src.api.routes.migration import get_dashboards
+    cm = _make_sync_config_manager([_mock_env])
+    
+    with pytest.raises(HTTPException) as exc:
+        await get_dashboards(env_id="wrong-env", config_manager=cm, _=None)
+    assert exc.value.status_code == 404
+
+# --- execute_migration tests ---
+
+@pytest.mark.asyncio
+async def test_execute_migration_success(_mock_env):
+    from src.api.routes.migration import execute_migration
+    from src.models.dashboard import DashboardSelection
+    
+    cm = _make_sync_config_manager([_mock_env, _mock_env]) # Need both source/target
+    tm = MagicMock()
+    tm.create_task = AsyncMock(return_value=MagicMock(id="task-123"))
+    
+    selection = DashboardSelection(
+        source_env_id="test-env-1",
+        target_env_id="test-env-1",
+        selected_ids=[1, 2]
+    )
+    
+    result = await execute_migration(selection=selection, config_manager=cm, task_manager=tm, _=None)
+    assert result["task_id"] == "task-123"
+    tm.create_task.assert_called_once()
+
+@pytest.mark.asyncio
+async def test_execute_migration_invalid_env_raises_400(_mock_env):
+    from src.api.routes.migration import execute_migration
+    from src.models.dashboard import DashboardSelection
+    
+    cm = _make_sync_config_manager([_mock_env])
+    selection = DashboardSelection(
+        source_env_id="test-env-1",
+        target_env_id="non-existent",
+        selected_ids=[1]
+    )
+    
+    with pytest.raises(HTTPException) as exc:
+        await execute_migration(selection=selection, config_manager=cm, task_manager=MagicMock(), _=None)
+    assert exc.value.status_code == 400
+
+
 # [/DEF:backend.src.api.routes.__tests__.test_migration_routes:Module]